Migrate to OFOptionsParser

FossilOrigin-Name: f642e9dfbf67a6be7bf37d9df2cf3b037537a29c74387f49b0a0e82d6816d616

src/.clang-format

@@ -15,3 +15,5 @@ ObjCPropertyAttributeOrder: [
     atomic, nonatomic,
     getter, setter
 ]
+IndentPPDirectives: AfterHash
+PPIndentWidth: 1

src/Cube.mm

@@ -8,8 +8,8 @@ OF_APPLICATION_DELEGATE(Cube)
 - (void)showMessage:(OFString *)msg
 {
 #ifdef _WIN32
-	MessageBoxW(NULL, msg.UTF16String, L"cube fatal error",
-	    MB_OK | MB_SYSTEMMODAL);
+	MessageBoxW(
+	    NULL, msg.UTF16String, L"cube fatal error", MB_OK | MB_SYSTEMMODAL);
 #else
 	[OFStdOut writeString:msg];
 #endif
@@ -98,73 +98,57 @@ keyrepeat(bool on)
 VARF(gamespeed, 10, 100, 1000, if (multiplayer()) gamespeed = 100);
 VARP(minmillis, 0, 5, 1000);
 
-int islittleendian = 1;
 int framesinmap = 0;
 
 - (void)applicationDidFinishLaunching:(OFNotification *)notification
 {
-	bool dedicated = false;
-	int fs = SDL_FULLSCREEN, par = 0, uprate = 0, maxcl = 4;
-	char *sdesc = "", *ip = "", *master = NULL, *passwd = "";
-	islittleendian = *((char *)&islittleendian);
-	int argc, *argcPtr;
-	char **argv, ***argvPtr;
-
-	[OFApplication.sharedApplication getArgumentCount: &argcPtr
-					andArgumentValues: &argvPtr];
-	argc = *argcPtr;
-	argv = *argvPtr;
+	bool dedicated, windowed;
+	int par = 0, uprate = 0, maxcl = 4;
+	OFString *__autoreleasing sdesc, *__autoreleasing ip;
+	OFString *__autoreleasing master, *__autoreleasing passwd;
 
 	processInitQueue();
 
 #define log(s) conoutf(@"init: %s", s)
 	log("sdl");
 
-	for (int i = 1; i < argc; i++) {
-		char *a = &argv[i][2];
-		if (argv[i][0] == '-')
-			switch (argv[i][1]) {
-			case 'd':
-				dedicated = true;
-				break;
-			case 't':
-				fs = 0;
-				break;
+	const OFOptionsParserOption options[] = {
+	    {'d', nil, 0, &dedicated, NULL}, {'t', nil, 0, &windowed, NULL},
+	    {'w', nil, 1, NULL, NULL}, {'h', nil, 1, NULL, NULL},
+	    {'u', nil, 1, NULL, NULL}, {'n', nil, 1, NULL, &sdesc},
+	    {'i', nil, 1, NULL, &ip}, {'m', nil, 1, NULL, &master},
+	    {'p', nil, 1, NULL, &passwd}, {'c', nil, 1, NULL, NULL}};
+	OFOptionsParser *optionsParser =
+	    [OFOptionsParser parserWithOptions:options];
+	OFUnichar option;
+	while ((option = [optionsParser nextOption]) != '\0') {
+		switch (option) {
 		case 'w':
-				scr_w = atoi(a);
+			scr_w = optionsParser.argument.longLongValue;
 			break;
 		case 'h':
-				scr_h = atoi(a);
+			scr_h = optionsParser.argument.longLongValue;
 			break;
 		case 'u':
-				uprate = atoi(a);
-				break;
-			case 'n':
-				sdesc = a;
-				break;
-			case 'i':
-				ip = a;
-				break;
-			case 'm':
-				master = a;
-				break;
-			case 'p':
-				passwd = a;
+			uprate = optionsParser.argument.longLongValue;
 			break;
 		case 'c':
-				maxcl = atoi(a);
+			maxcl = optionsParser.argument.longLongValue;
 			break;
-			default:
+		case ':':
+		case '=':
+		case '?':
 			conoutf(@"unknown commandline option");
+			[OFApplication terminateWithStatus:1];
+		}
 	}
-		else
-			conoutf(@"unknown commandline argument");
-	};
 
-#ifdef _DEBUG
-	par = SDL_INIT_NOPARACHUTE;
-	fs = 0;
-#endif
+	if (sdesc == nil)
+		sdesc = @"";
+	if (ip == nil)
+		ip = @"";
+	if (passwd == nil)
+		passwd = @"";
 
 	if (SDL_Init(SDL_INIT_TIMER | SDL_INIT_VIDEO | par) < 0)
 		fatal("Unable to initialize SDL");
@@ -174,8 +158,9 @@ int framesinmap = 0;
 		fatal("Unable to initialise network module");
 
 	initclient();
-	initserver(dedicated, uprate, sdesc, ip, master, passwd,
-	    maxcl); // never returns if dedicated
+	// never returns if dedicated
+	initserver(dedicated, uprate, sdesc.UTF8String, ip.UTF8String,
+	    master.UTF8String, passwd, maxcl);
 
 	log("world");
 	empty_world(7, true);
@@ -186,7 +171,8 @@ int framesinmap = 0;
 
 	log("video: mode");
 	SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, 1);
-	if (SDL_SetVideoMode(scr_w, scr_h, 0, SDL_OPENGL | fs) == NULL)
+	if (SDL_SetVideoMode(scr_w, scr_h, 0,
+	        SDL_OPENGL | (!windowed ? SDL_FULLSCREEN : 0)) == NULL)
 		fatal("Unable to create OpenGL screen");
 
 	log("video: misc");

src/protos.h

@@ -214,8 +214,8 @@ extern void rendermodel(char *mdl, int frame, int range, int tex, float rad,
 extern mapmodelinfo *getmminfo(int i);
 
 // server
-extern void initserver(bool dedicated, int uprate, char *sdesc, char *ip,
-    char *master, char *passwd, int maxcl);
+extern void initserver(bool dedicated, int uprate, const char *sdesc,
+    const char *ip, const char *master, OFString *passwd, int maxcl);
 extern void cleanupserver();
 extern void localconnect();
 extern void localdisconnect();
@@ -223,14 +223,14 @@ extern void localclienttoserver(struct _ENetPacket *);
 extern void serverslice(int seconds, unsigned int timeout);
 extern void putint(uchar *&p, int n);
 extern int getint(uchar *&p);
-extern void sendstring(char *t, uchar *&p);
+extern void sendstring(const char *t, uchar *&p);
 extern void startintermission();
 extern void restoreserverstate(vector<entity> &ents);
 extern uchar *retrieveservers(uchar *buf, int buflen);
 extern char msgsizelookup(int msg);
 extern void serverms(int mode, int numplayers, int minremain, char *smapname,
     int seconds, bool isfull);
-extern void servermsinit(const char *master, char *sdesc, bool listen);
+extern void servermsinit(const char *master, const char *sdesc, bool listen);
 extern void sendmaps(int n, string mapname, int mapsize, uchar *mapdata);
 extern ENetPacket *recvmap(int n);
 

src/savegamedemo.mm

@@ -3,7 +3,11 @@
 
 #include "cube.h"
 
-extern int islittleendian;
+#ifdef OF_BIG_ENDIAN
+static const int islittleendian = 0;
+#else
+static const int islittleendian = 1;
+#endif
 
 gzFile f = NULL;
 bool demorecording = false;

src/server.mm

@@ -46,7 +46,7 @@ restoreserverstate(
 int interm = 0, minremain = 0, mapend = 0;
 bool mapreload = false;
 
-char *serverpassword = "";
+static OFString *serverpassword = @"";
 
 bool isdedicated;
 ENetHost *serverhost = NULL;
@@ -308,7 +308,7 @@ send_welcome(int n)
 	putint(p, n);
 	putint(p, PROTOCOL_VERSION);
 	putint(p, smapname[0]);
-	sendstring(serverpassword, p);
+	sendstring(serverpassword.UTF8String, p);
 	putint(p, clients.length() > maxclients);
 	if (smapname[0]) {
 		putint(p, SV_MAPCHANGE);
@@ -509,8 +509,8 @@ localconnect()
 };
 
 void
-initserver(bool dedicated, int uprate, char *sdesc, char *ip, char *master,
-    char *passwd, int maxcl)
+initserver(bool dedicated, int uprate, const char *sdesc, const char *ip,
+    const char *master, OFString *passwd, int maxcl)
 {
 	serverpassword = passwd;
 	maxclients = maxcl;

src/serverms.mm

@@ -147,7 +147,7 @@ serverms(int mode, int numplayers, int minremain, char *smapname, int seconds,
 };
 
 void
-servermsinit(const char *master, char *sdesc, bool listen)
+servermsinit(const char *master, const char *sdesc, bool listen)
 {
 	const char *mid = strstr(master, "/");
 	if (!mid)

src/serverutil.mm

@@ -43,7 +43,7 @@ getint(uchar *&p)
 };
 
 void
-sendstring(char *t, uchar *&p)
+sendstring(const char *t, uchar *&p)
 {
 	while (*t)
 		putint(p, *t++);
@@ -184,7 +184,7 @@ main(int argc, char *argv[])
 
 	if (enet_initialize() < 0)
 		fatal("Unable to initialise network module");
-	initserver(true, uprate, sdesc, ip, master, passwd, maxcl);
+	initserver(true, uprate, sdesc, ip, master, @(passwd), maxcl);
 	return 0;
-};
+}
 #endif