Change how roster items are stored.

configure.ac

@@ -59,6 +59,6 @@ dnl and add OBJCPPA.FLAGS to CPPFLAGS, thus we need to AC_SUBST these ourself
 AC_SUBST(CPP)
 AC_SUBST(CPPFLAGS)
 
-AC_SUBST(PACKAGE, ObjFW)
+AC_SUBST(PACKAGE, ObjXMPP)
 AC_CONFIG_FILES([buildsys.mk extra.mk])
 AC_OUTPUT

src/XMPPRoster.h

@@ -28,13 +28,14 @@
 @interface XMPPRoster: OFObject
 {
 	XMPPConnection *connection;
-	OFMutableDictionary *groups;
+	OFMutableDictionary *rosterItems;
 }
 
 - initWithConnection: (XMPPConnection*)conn;
 - (void)XMPP_addRosterItem: (XMPPRosterItem*)rosterItem;
-- (OFArray*)groups;
+- (void)XMPP_updateRosterItem: (XMPPRosterItem*)rosterItem;
-- (OFArray*)rosterItemsInGroup: (OFString*)group;
+- (void)XMPP_deleteRosterItem: (XMPPRosterItem*)rosterItem;
+- (OFDictionary*)rosterItems;
 - (void)addRosterItem: (XMPPRosterItem*)rosterItem;
 - (void)updateRosterItem: (XMPPRosterItem*)rosterItem;
 - (void)deleteRosterItem: (XMPPRosterItem*)rosterItem;

src/XMPPRoster.m

@@ -33,7 +33,7 @@
 
 	@try {
 		connection = [conn retain];
-		groups = [[OFMutableDictionary alloc] init];
+		rosterItems = [[OFMutableDictionary alloc] init];
 	} @catch (id e) {
 		[self release];
 		@throw e;
@@ -51,56 +51,23 @@
 
 - (void)XMPP_addRosterItem: (XMPPRosterItem*)rosterItem
 {
-	if ([[rosterItem groups] count] > 0) {
+	return [self XMPP_updateRosterItem: rosterItem];
-		OFEnumerator *enumerator;
-		OFString *group;
-
-		enumerator = [[rosterItem groups] objectEnumerator];
-		while ((group = [enumerator nextObject]) != nil) {
-			OFMutableArray *rosterGroup =
-			    [groups objectForKey: group];
-
-			if (rosterGroup == nil) {
-				rosterGroup = [OFMutableArray array];
-				[groups setObject: rosterGroup
-					   forKey: group];
-			}
-
-			[rosterGroup addObject: rosterItem];
-		}
-	} else {
-		OFMutableArray *rosterGroup = [groups objectForKey: @""];
-
-		if (rosterGroup == nil) {
-			rosterGroup = [OFMutableArray array];
-			[groups setObject: rosterGroup
-				   forKey: @""];
-		}
-
-		[rosterGroup addObject: rosterItem];
-	}
 }
 
-- (OFArray*)groups
+- (void)XMPP_updateRosterItem: (XMPPRosterItem*)rosterItem
 {
-	OFMutableArray *ret = [OFMutableArray array];
+	[rosterItems setObject: rosterItem
-	OFEnumerator *enumerator;
+			forKey: [[rosterItem JID] bareJID]];
-	OFString *group;
-
-	enumerator = [groups keyEnumerator];
-	while ((group = [enumerator nextObject]) != nil)
-		[ret addObject: group];
-
-	ret->isa = [OFArray class];
-	return ret;
 }
 
-- (OFArray*)rosterItemsInGroup: (OFString*)group
+- (void)XMPP_deleteRosterItem: (XMPPRosterItem*)rosterItem
 {
-	if (group == nil)
+	[rosterItems removeObjectForKey: [[rosterItem JID] bareJID]];
-		group = @"";
+}
 
-	return [[[groups objectForKey: group] copy] autorelease];
+- (OFDictionary*)rosterItems
+{
+	return [[rosterItems copy] autorelease];
 }
 
 - (void)addRosterItem: (XMPPRosterItem*)rosterItem

tests/test.m

@@ -126,14 +126,8 @@ OF_APPLICATION_DELEGATE(AppDelegate)
 - (void)connectionDidReceiveRoster :(XMPPConnection*)conn
 {
 	XMPPPresence *pres;
-	OFEnumerator *enumerator;
-	OFString *group;
 
-	of_log(@"Got roster! Groups: %@", [[conn roster] groups]);
+	of_log(@"Got roster: %@", [[conn roster] rosterItems]);
-	enumerator = [[[conn roster] groups] objectEnumerator];
-	while ((group = [enumerator nextObject]) != nil)
-		of_log(@"Group %@: %@", group,
-		    [[conn roster] rosterItemsInGroup: group]);
 
 	pres = [XMPPPresence presence];
 	[pres addPriority: 10];