ObjFW/ObjXMPP
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sure all properties are nonatomic

Browse source
This commit is contained in:
Jonathan Schleifer 2017-07-23 14:07:40 +02:00
parent 8c991b50d2
commit e0ff07860a
No known key found for this signature in database
GPG key ID: 28D65178B37F33E3
6 changed files with 19 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
configure.ac
View file

@ -24,6 +24,8 @@ OBJCFLAGS="$OBJCFLAGS -Wall $($OBJFW_CONFIG --objcflags)"
LDFLAGS="$LDFLAGS $($OBJFW_CONFIG --ldflags)" LDFLAGS="$LDFLAGS $($OBJFW_CONFIG --ldflags)"
LIBS="$LIBS $($OBJFW_CONFIG --libs)" LIBS="$LIBS $($OBJFW_CONFIG --libs)"
AX_CHECK_COMPILER_FLAGS(-Watomic-properties,
[OBJCFLAGS="$OBJCFLAGS -Watomic-properties"])
AX_CHECK_COMPILER_FLAGS(-Wdocumentation, AX_CHECK_COMPILER_FLAGS(-Wdocumentation,
[OBJCFLAGS="$OBJCFLAGS -Wdocumentation"]) [OBJCFLAGS="$OBJCFLAGS -Wdocumentation"])

12
src/XMPPConnection.h
View file

@ -219,12 +219,12 @@ OF_ASSUME_NONNULL_BEGIN
/*! /*!
* The port to connect to. * The port to connect to.
*/ */
@property uint16_t port; @property (nonatomic) uint16_t port;
/*! /*!
* An object for data storage, conforming to the XMPPStorage protocol. * An object for data storage, conforming to the XMPPStorage protocol.
*/ */
@property OF_NULLABLE_PROPERTY (assign) id <XMPPStorage> dataStorage; @property OF_NULLABLE_PROPERTY (nonatomic, assign) id <XMPPStorage> dataStorage;
/*! /*!
* The socket used for the connection. * The socket used for the connection.
@ -234,22 +234,22 @@ OF_ASSUME_NONNULL_BEGIN
/*! /*!
* Whether encryption is required. * Whether encryption is required.
*/ */
@property bool encryptionRequired; @property (nonatomic) bool encryptionRequired;
/*! /*!
* Whether the connection is encrypted. * Whether the connection is encrypted.
*/ */
@property (readonly) bool encrypted; @property (readonly, nonatomic) bool encrypted;
/*! /*!
* Whether roster versioning is supported. * Whether roster versioning is supported.
*/ */
@property (readonly) bool supportsRosterVersioning; @property (readonly, nonatomic) bool supportsRosterVersioning;
/*! /*!
* Whether stream management is supported. * Whether stream management is supported.
*/ */
@property (readonly) bool supportsStreamManagement; @property (readonly, nonatomic) bool supportsStreamManagement;
/*! /*!
* Creates a new autoreleased XMPPConnection. * Creates a new autoreleased XMPPConnection.

4
src/XMPPDiscoEntity.h
View file

@ -48,12 +48,12 @@ OF_ASSUME_NONNULL_BEGIN
* This usually contains at least all immediate child nodes, but may contain * This usually contains at least all immediate child nodes, but may contain
* any number of nodes nested more deeply. * any number of nodes nested more deeply.
*/ */
@property (readonly) OFDictionary *discoNodes; @property (readonly, nonatomic) OFDictionary *discoNodes;
/*! /*!
* The node advertised for the entity's capabilites. * The node advertised for the entity's capabilites.
*/ */
@property (readonly) OFString *capsNode; @property (readonly, nonatomic) OFString *capsNode;
+ (instancetype)discoNodeWithJID: (XMPPJID *)JID + (instancetype)discoNodeWithJID: (XMPPJID *)JID
node: (nullable OFString *)node OF_UNAVAILABLE; node: (nullable OFString *)node OF_UNAVAILABLE;

6
src/XMPPMessage.h
View file

@ -29,8 +29,10 @@ OF_ASSUME_NONNULL_BEGIN
* @brief A class describing a message stanza. * @brief A class describing a message stanza.
*/ */
@interface XMPPMessage: XMPPStanza @interface XMPPMessage: XMPPStanza
/*! The text content of the body of the message. */ /*!
@property (copy) OFString *body; * The text content of the body of the message.
*/
@property (nonatomic, copy) OFString *body;
/*! /*!
* @brief Creates a new autoreleased XMPPMessage. * @brief Creates a new autoreleased XMPPMessage.

2
src/XMPPRoster.h
View file

@ -72,7 +72,7 @@ OF_ASSUME_NONNULL_BEGIN
/*! /*!
* @brief The connection to which the roster belongs * @brief The connection to which the roster belongs
*/ */
@property (readonly, assign) XMPPConnection *connection; @property (readonly, nonatomic) XMPPConnection *connection;
/*! /*!
* @brief An object for data storage, conforming to the XMPPStorage protocol. * @brief An object for data storage, conforming to the XMPPStorage protocol.

8
src/XMPPSRVLookup.h
View file

@ -38,10 +38,10 @@ OF_ASSUME_NONNULL_BEGIN
OFString *_target; OFString *_target;
} }
@property (readonly) uint16_t priority; @property (readonly, nonatomic) uint16_t priority;
@property (readonly) uint16_t weight; @property (readonly, nonatomic) uint16_t weight;
@property uint32_t accumulatedWeight; @property (nonatomic) uint32_t accumulatedWeight;
@property (readonly) uint16_t port; @property (readonly, nonatomic) uint16_t port;
@property (readonly, nonatomic) OFString *target; @property (readonly, nonatomic) OFString *target;
+ (instancetype)entryWithPriority: (uint16_t)priority + (instancetype)entryWithPriority: (uint16_t)priority