Add methods to generate error and result replies for IQ stanzas

src/XMPPConnection.m

@@ -574,23 +574,8 @@
 
 	if (!handled && ![[iq type] isEqual: @"error"]
 		     && ![[iq type] isEqual: @"result"]) {
-		XMPPJID *from = [iq from];
+		[self sendStanza: [iq errorIQWithType: @"cancel"
-		XMPPJID *to = [iq to];
+					    condition: @"service-unavailable"]];
-		OFXMLElement *error;
-
-		[iq setType: @"error"];
-		[iq setTo: from];
-		[iq setFrom: to];
-
-		error = [OFXMLElement elementWithName: @"error"];
-		[error addAttributeWithName: @"type"
-				stringValue: @"cancel"];
-		[error addChild:
-		    [OFXMLElement elementWithName: @"service-unavailable"
-					namespace: XMPP_NS_STANZAS]];
-		[iq addChild: error];
-
-		[self sendStanza: iq];
 	}
 }
 

src/XMPPIQ.h

@@ -46,4 +46,33 @@
  */
 - initWithType: (OFString*)type
 	    ID: (OFString*)ID;
+
+/**
+ * Generates a result IQ for the receiving object
+ *
+ * \return A new autoreleased XMPPIQ
+ */
+- (XMPPIQ*)resultIQ;
+
+/**
+ * Generates a error IQ for the receiving object
+ *
+ * \param type A error type as defined by RFC 6120
+ * \param condition A error condition as defined by RFC 6120
+ * \param text A descriptive text
+ * \return A new autoreleased XMPPIQ
+ */
+- (XMPPIQ*)errorIQWithType: (OFString*)type
+		 condition: (OFString*)condition
+		      text: (OFString*)text;
+
+/**
+ * Generates a error IQ for the receiving object
+ *
+ * \param type A error type as defined by RFC 6120
+ * \param condition A defined conditions from RFC 6120
+ * \return A new autoreleased XMPPIQ
+ */
+- (XMPPIQ*)errorIQWithType: (OFString*)type
+		 condition: (OFString*)condition;
 @end

src/XMPPIQ.m

@@ -21,6 +21,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 
+#import "namespaces.h"
 #import "XMPPIQ.h"
 
 @implementation XMPPIQ
@@ -50,4 +51,48 @@
 
 	return self;
 }
+
+- (XMPPIQ*)resultIQ
+{
+	XMPPIQ *ret = [XMPPIQ IQWithType: @"result"
+				      ID: [self ID]];
+	[ret setTo: [self from]];
+	[ret setFrom: nil];
+	return ret;
+}
+
+- (XMPPIQ*)errorIQWithType: (OFString*)type_
+		 condition: (OFString*)condition
+		      text: (OFString*)text
+{
+	XMPPIQ *ret = [XMPPIQ IQWithType: @"error"
+				      ID: [self ID]];
+	OFAutoreleasePool *pool = [[OFAutoreleasePool alloc] init];
+	OFXMLElement *error = [OFXMLElement elementWithName: @"error"
+						  namespace: XMPP_NS_CLIENT];
+
+	[error addAttributeWithName: @"type"
+			stringValue: type_];
+	[error addChild: [OFXMLElement elementWithName: condition
+					     namespace: XMPP_NS_STANZAS]];
+	if (text)
+		[error addChild: [OFXMLElement elementWithName: @"text"
+						     namespace: XMPP_NS_STANZAS
+						   stringValue: text]];
+	[ret addChild: error];
+	[ret setTo: [self from]];
+	[ret setFrom: nil];
+
+	[pool release];
+
+	return ret;
+}
+
+- (XMPPIQ*)errorIQWithType: (OFString*)type_
+		 condition: (OFString*)condition
+{
+	return [self errorIQWithType: type_
+			   condition: condition
+				text: nil];
+}
 @end

src/XMPPRoster.m

@@ -162,10 +162,7 @@
 	}
 
 	if (isPush) {
-		XMPPIQ *response = [XMPPIQ IQWithType: @"result"
+		[connection sendStanza: [iq resultIQ]];
-						   ID: [iq ID]];
-		[response setTo: [iq from]];
-		[connection sendStanza: response];
 	} else {
 		if ([[connection delegate] respondsToSelector:
 		     @selector(connectionDidReceiveRoster:)])