Make method names more consistent with ObjFW.

src/XMPPCallback.h

@@ -31,18 +31,21 @@ typedef void(^xmpp_callback_block_t)(XMPPConnection*, XMPPIQ*);
 
 @interface XMPPCallback: OFObject
 {
-	id object;
+	id target;
 	SEL selector;
+#ifdef OF_HAVE_BLOCKS
+	xmpp_callback_block_t block;
+#endif
 }
 
 #ifdef OF_HAVE_BLOCKS
-+ callbackWithCallbackBlock: (xmpp_callback_block_t)callback;
++ callbackWithBlock: (xmpp_callback_block_t)callback;
-- initWithCallbackBlock: (xmpp_callback_block_t)callback;
+- initWithBlock: (xmpp_callback_block_t)callback;
 #endif
 
-+ callbackWithCallbackObject: (id)object
++ callbackWithTarget: (id)target
 	    selector: (SEL)selector;
-- initWithCallbackObject: (id)object
+- initWithTarget: (id)target
 	selector: (SEL)selector;
 
 - (void)runWithIQ: (XMPPIQ*)iq

src/XMPPCallback.m

@@ -28,34 +28,39 @@
 
 @implementation XMPPCallback
 #ifdef OF_HAVE_BLOCKS
-+ callbackWithCallbackBlock: (xmpp_callback_block_t)callback
++ callbackWithBlock: (xmpp_callback_block_t)block
 {
-	return [[[self alloc] initWithCallbackBlock: callback] autorelease];
+	return [[(XMPPCallback*)[self alloc] initWithBlock: block] autorelease];
 }
 
-- initWithCallbackBlock: (xmpp_callback_block_t)callback
+- initWithBlock: (xmpp_callback_block_t)block_
 {
 	self = [super init];
 
-	object = [callback copy];
+	@try {
+		block = [block_ copy];
+	} @catch (id e) {
+		[self release];
+		@throw e;
+	}
 
 	return self;
 }
 #endif
 
-+ callbackWithCallbackObject: (id)object_
++ callbackWithTarget: (id)target
-		    selector: (SEL)selector_
+	    selector: (SEL)selector
 {
-	return [[[self alloc] initWithCallbackObject: object_
+	return [[[self alloc] initWithTarget: target
-					    selector: selector_] autorelease];
+				    selector: selector] autorelease];
 }
 
-- initWithCallbackObject: (id)object_
+- initWithTarget: (id)target_
 	selector: (SEL)selector_
 {
 	self = [super init];
 
-	object = object_;
+	target = [target_ retain];
 	selector = selector_;
 
 	return self;
@@ -63,6 +68,11 @@
 
 - (void)dealloc
 {
+	[target release];
+#ifdef OF_HAVE_BLOCKS
+	[block release];
+#endif
+
 	[super dealloc];
 }
 
@@ -70,11 +80,11 @@
        connection: (XMPPConnection*)connection
 {
 #ifdef OF_HAVE_BLOCKS
-	if ([object isKindOfClass: [OFBlock class]])
+	if (block != NULL)
-		((xmpp_callback_block_t)object)(connection, iq);
+		block(connection, iq);
 	else
 #endif
-		[object performSelector: selector
+		[target performSelector: selector
 			     withObject: connection
 			     withObject: iq];
 }

src/XMPPConnection.h

@@ -316,7 +316,7 @@
  *		   must take exactly one parameter of type XMPPIQ*
  */
 -   (void)sendIQ: (XMPPIQ*)iq
-  withCallbackObject: (id)object
+  callbackTarget: (id)target
 	selector: (SEL)selector;
 
 #ifdef OF_HAVE_BLOCKS
@@ -326,7 +326,7 @@
  * \param callback The callback block
  */
 -  (void)sendIQ: (XMPPIQ*)iq
-  withCallbackBlock: (xmpp_callback_block_t)block;
+  callbackBlock: (xmpp_callback_block_t)block;
 #endif
 
 /**
@@ -370,10 +370,10 @@
 - (void)XMPP_handlePresence: (XMPPPresence*)presence;
 - (void)XMPP_handleFeatures: (OFXMLElement*)element;
 - (void)XMPP_handleResourceBindForConnection: (XMPPConnection*)connection
-				      withIQ: (XMPPIQ*)iq;
+					  IQ: (XMPPIQ*)iq;
 - (void)XMPP_sendSession;
 - (void)XMPP_handleSessionForConnection: (XMPPConnection*)connection
-				 withIQ: (XMPPIQ*)iq;
+				     IQ: (XMPPIQ*)iq;
 - (OFString*)XMPP_IDNAToASCII: (OFString*)domain;
 - (XMPPMulticastDelegate*)XMPP_delegates;
 /// \endcond

src/XMPPConnection.m

@@ -470,7 +470,7 @@
 }
 
 -   (void)sendIQ: (XMPPIQ*)iq
-  withCallbackObject: (id)object
+  callbackTarget: (id)target
 	selector: (SEL)selector
 {
 	OFAutoreleasePool *pool;
@@ -480,7 +480,7 @@
 		[iq setID: [self generateStanzaID]];
 
 	pool = [[OFAutoreleasePool alloc] init];
-	callback = [XMPPCallback callbackWithCallbackObject: object
+	callback = [XMPPCallback callbackWithTarget: target
 					   selector: selector];
 	[callbacks setObject: callback
 		      forKey: [iq ID]];
@@ -491,7 +491,7 @@
 
 #ifdef OF_HAVE_BLOCKS
 -  (void)sendIQ: (XMPPIQ*)iq
-  withCallbackBlock: (xmpp_callback_block_t)block;
+  callbackBlock: (xmpp_callback_block_t)block
 {
 	OFAutoreleasePool *pool;
 	XMPPCallback *callback;
@@ -500,7 +500,7 @@
 		[iq setID: [self generateStanzaID]];
 
 	pool = [[OFAutoreleasePool alloc] init];
-	callback = [XMPPCallback callbackWithCallbackBlock: block];
+	callback = [XMPPCallback callbackWithBlock: block];
 	[callbacks setObject: callback
 		      forKey: [iq ID]];
 	[pool release];
@@ -1039,9 +1039,9 @@
 	[iq addChild: bind];
 
 	[self	    sendIQ: iq
-	    withCallbackObject: self
+	    callbackTarget: self
 		  selector: @selector(XMPP_handleResourceBindForConnection:
-				    withIQ:)];
+				IQ:)];
 }
 
 - (void)XMPP_sendStreamError: (OFString*)condition
@@ -1065,7 +1065,7 @@
 }
 
 - (void)XMPP_handleResourceBindForConnection: (XMPPConnection*)connection
-				      withIQ: (XMPPIQ*)iq
+					  IQ: (XMPPIQ*)iq
 {
 	OFXMLElement *bindElement;
 	OFXMLElement *jidElement;
@@ -1100,13 +1100,12 @@
 	[iq addChild: [OFXMLElement elementWithName: @"session"
 					  namespace: XMPP_NS_SESSION]];
 	[self	    sendIQ: iq
-	    withCallbackObject: self
+	    callbackTarget: self
-		      selector: @selector(
+		  selector: @selector(XMPP_handleSessionForConnection:IQ:)];
-				    XMPP_handleSessionForConnection:withIQ:)];
 }
 
 - (void)XMPP_handleSessionForConnection: (XMPPConnection*)connection
-				 withIQ: (XMPPIQ*)iq
+				     IQ: (XMPPIQ*)iq
 {
 	if (![[iq type] isEqual: @"result"])
 		assert(0);

src/XMPPRoster.h

@@ -156,7 +156,7 @@
 /// \cond internal
 - (void)XMPP_updateRosterItem: (XMPPRosterItem*)rosterItem;
 - (void)XMPP_handleInitialRosterForConnection: (XMPPConnection*)connection
-				       withIQ: (XMPPIQ*)iq;
+					   IQ: (XMPPIQ*)iq;
 - (XMPPRosterItem*)XMPP_rosterItemWithXMLElement: (OFXMLElement*)element;
 /// \endcond
 @end

src/XMPPRoster.m

@@ -98,9 +98,9 @@
 	[iq addChild: query];
 
 	[connection sendIQ: iq
-	    withCallbackObject: self
+	    callbackTarget: self
 		  selector: @selector(XMPP_handleInitialRosterForConnection:
-			withIQ:)];
+				IQ:)];
 }
 
 - (BOOL)connection: (XMPPConnection*)connection_
@@ -306,7 +306,7 @@
 }
 
 - (void)XMPP_handleInitialRosterForConnection: (XMPPConnection*)connection_
-				       withIQ: (XMPPIQ*)iq
+					   IQ: (XMPPIQ*)iq
 {
 	OFXMLElement *rosterElement;
 	OFEnumerator *enumerator;

tests/test.m

@@ -170,7 +170,7 @@ OF_APPLICATION_DELEGATE(AppDelegate)
 	[iq addChild: [OFXMLElement elementWithName: @"ping"
 					  namespace: @"urn:xmpp:ping"]];
 	[conn	   sendIQ: iq
-	    withCallbackBlock: ^ (XMPPConnection *c, XMPPIQ *resp) {
+	    callbackBlock: ^ (XMPPConnection *c, XMPPIQ *resp) {
 		of_log(@"Ping response: %@", resp);
 	}];
 #endif