From 932d805e9519812d873e70269a281092c9c0c54d Mon Sep 17 00:00:00 2001
From: Jonathan Schleifer <js@webkeks.org>
Date: Thu, 17 Mar 2011 21:36:04 +0100
Subject: [PATCH] Improve stanza handling and call delegate for iq, message and
 presence.

---
 src/XMPPConnection.m | 86 ++++++++++++++++++++++++++++++++++++--------
 tests/test.m         | 26 +++++++++++++-
 2 files changed, 96 insertions(+), 16 deletions(-)

diff --git a/src/XMPPConnection.m b/src/XMPPConnection.m
index 07042fd..dbbe1e4 100644
--- a/src/XMPPConnection.m
+++ b/src/XMPPConnection.m
@@ -34,6 +34,8 @@
 #import "XMPPStanza.h"
 #import "XMPPJID.h"
 #import "XMPPIQ.h"
+#import "XMPPMessage.h"
+#import "XMPPPresence.h"
 #import "XMPPExceptions.h"
 
 #define NS_BIND @"urn:ietf:params:xml:ns:xmpp-bind"
@@ -303,6 +305,30 @@
 		[self _sendResourceBind];
 }
 
+- (void)_handleIQ: (XMPPIQ*)iq
+{
+	// FIXME: More checking!
+	if ([iq.ID isEqual: @"bind0"] && [iq.type isEqual: @"result"]) {
+		[self _handleResourceBind: iq];
+		return;
+	}
+
+	[delegate connection: self
+		didReceiveIQ: iq];
+}
+
+- (void)_handleMessage: (XMPPMessage*)msg
+{
+	[delegate connection: self
+	   didReceiveMessage: msg];
+}
+
+- (void)_handlePresence: (XMPPPresence*)pres
+{
+	[delegate connection: self
+	  didReceivePresence: pres];
+}
+
 - (void)elementBuilder: (OFXMLElementBuilder*)b
        didBuildElement: (OFXMLElement*)elem
 {
@@ -310,10 +336,34 @@
 	[elem setPrefix: @"stream"
 	   forNamespace: NS_STREAM];
 
-	if ([elem.name isEqual: @"features"] &&
-	    [elem.namespace isEqual: NS_STREAM]) {
-		[self _handleFeatures: elem];
-		return;
+	if ([elem.namespace isEqual: NS_CLIENT]) {
+		if ([elem.name isEqual: @"iq"]) {
+			[self _handleIQ: [XMPPIQ stanzaWithElement: elem]];
+			return;
+		}
+
+		if ([elem.name isEqual: @"message"]) {
+			[self _handleMessage:
+			    [XMPPMessage stanzaWithElement: elem]];
+			return;
+		}
+
+		if ([elem.name isEqual: @"presence"]) {
+			[self _handlePresence:
+			    [XMPPPresence stanzaWithElement: elem]];
+			return;
+		}
+
+		assert(0);
+	}
+
+	if ([elem.namespace isEqual: NS_STREAM]) {
+		if ([elem.name isEqual: @"features"]) {
+			[self _handleFeatures: elem];
+			return;
+		}
+
+		assert(0);
 	}
 
 	if ([elem.namespace isEqual: NS_STARTTLS]) {
@@ -324,9 +374,14 @@
 			/* Stream restart */
 			parser.delegate = self;
 			[self _startStream];
-		} else if ([elem.name isEqual: @"failure"])
+			return;
+		}
+
+		if ([elem.name isEqual: @"failure"])
 			/* TODO: Find/create an exception to throw here */
 			@throw [OFException newWithClass: isa];
+
+		assert(0);
 	}
 
 	if ([elem.namespace isEqual: NS_SASL]) {
@@ -346,7 +401,10 @@
 				[response stringByBase64Encoding]]];
 
 			[self sendStanza: responseTag];
-		} else if ([elem.name isEqual: @"success"]) {
+			return;
+		}
+
+		if ([elem.name isEqual: @"success"]) {
 			[authModule parseServerFinalMessage:
 			    [OFDataArray dataArrayWithBase64EncodedString:
 				[elem.children.firstObject stringValue]]];
@@ -355,7 +413,10 @@
 			/* Stream restart */
 			parser.delegate = self;
 			[self _startStream];
-		} else if ([elem.name isEqual: @"failure"]) {
+			return;
+		}
+
+		if ([elem.name isEqual: @"failure"]) {
 			of_log(@"Auth failed!");
 			// FIXME: Do more parsing/handling
 			@throw [XMPPAuthFailedException
@@ -363,16 +424,11 @@
 			      connection: self
 				  reason: [elem stringValue]];
 		}
+
+		assert(0);
 	}
 
-	if ([elem.name isEqual: @"iq"] &&
-	    [elem.namespace isEqual: NS_CLIENT]) {
-		XMPPIQ *iq = [XMPPIQ stanzaWithElement: elem];
-
-		// FIXME: More checking!
-		if ([iq.ID isEqual: @"bind0"] && [iq.type isEqual: @"result"])
-			[self _handleResourceBind: iq];
-	}
+	assert(0);
 }
 
 - (void)elementBuilder: (OFXMLElementBuilder*)b
diff --git a/tests/test.m b/tests/test.m
index 7e993b2..b8b0011 100644
--- a/tests/test.m
+++ b/tests/test.m
@@ -32,7 +32,7 @@
 #import "XMPPMessage.h"
 #import "XMPPPresence.h"
 
-@interface AppDelegate: OFObject
+@interface AppDelegate: OFObject <XMPPConnectionDelegate>
 {
 	XMPPConnection *conn;
 }
@@ -84,6 +84,7 @@ OF_APPLICATION_DELEGATE(AppDelegate)
 	    isEqual: @"bob@localhost, alice@localhost, get, 42"]));
 
 	conn = [[XMPPConnection alloc] init];
+	conn.delegate = self;
 
 	if (arguments.count != 3) {
 		of_log(@"Invalid count of command line arguments!");
@@ -103,4 +104,27 @@ OF_APPLICATION_DELEGATE(AppDelegate)
 		of_log(@"%@", e);
 	}
 }
+
+- (void)connectionWasClosed: (XMPPConnection*)conn
+{
+	of_log(@"Connection was closed!");
+}
+
+- (void)connection: (XMPPConnection*)conn
+      didReceiveIQ: (XMPPIQ*)iq
+{
+	of_log(@"IQ: %@", iq);
+}
+
+-  (void)connection: (XMPPConnection*)conn
+  didReceiveMessage: (XMPPMessage*)msg
+{
+	of_log(@"Message: %@", msg);
+}
+
+-   (void)connection: (XMPPConnection*)conn
+  didReceivePresence: (XMPPPresence*)pres
+{
+	of_log(@"Presence: %@", pres);
+}
 @end